-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add Candidate Prompt or Warning for Election Creation to Prevent Immediate Election Start Without Candidates #73
Comments
Hi @zain171m , I would like to work on this issue. Could you please Assign me this issue. |
Hi @zain171m , Can you please assign me this issue |
Hi @Ronnieraj37, I would like to work on this issue. Could you please assign me this issue. |
Hey @zain171m Pl add in more details on how you would implement Option 1. Will this include doing it from the blockchain contracts side as well? @shreyam7713 @Shri1927 @SachinSaiTej Please give your reviews as well. |
i think we should add a condition to check the number of candidates to be alteast 2 before starting the election. Voting for a single item/member doesnot make any sense as the result will always be unanimous and same. |
@Ronnieraj37 There could be multiple ways to tackle this issue. We can pass candidates as parameters at the time we create election. |
you’d modify the election creation process so that users are required to add candidates before setting the election start time. This ensures that the election will have candidates when it begins, preventing the issue of starting an election with no candidates. |
and the second solution |
@Ronnieraj37 I would like to work on this issue. Could you please assign me this issue. This will boost my responsiblity |
@Ronnieraj37 here is the complete POC for this issue Screen.Recording.2024-12-27.153812.mp4while creating an election we would pass the candidates as arguments in createElection() function |
Hey @zain171m and @rairohit17 your solution looks good. Also what if user add 2 candidates while creating and removes them before the election starts? Do you suggest we should have something for that as well? @zain171m and @rairohit17 can you guys work together as @rairohit17 has already made the frontend changes we can use it after changes are pushed from @zain171m ? |
Context:
When creating an election in Agora Blockchain web app, the user is asked to set a start and end date/time but not to add candidates initially. If the user sets the start time to the current time, the election begins immediately, preventing further addition of candidates.
Problem:
I set the election start time to the current time, thinking I could add candidates later. The election started automatically, and I couldn't add any candidates.
Proposed Enhancement:
Expected Outcome:
This change would improve the user experience by preventing accidental election starts without candidates.
Suggested Labels:
Screenshots:
Current Election Creation UI:
The text was updated successfully, but these errors were encountered: