Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-ai-ml needs typing updates for mypy version 1.14.1 #39306

Open
azure-sdk opened this issue Jan 19, 2025 · 2 comments
Open

azure-ai-ml needs typing updates for mypy version 1.14.1 #39306

azure-sdk opened this issue Jan 19, 2025 · 2 comments
Assignees
Labels
Machine Learning mypy Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 19, 2025

ACTION NEEDED: This version of mypy will be merged on 2025-04-14. The build will begin to fail for this library if errors are not fixed.

Library name: azure-ai-ml
Mypy version: 1.14.1
Mypy errors: Link to build (2025-01-26)
How to fix: Run the next-mypy tox command at the library package-level and resolve the typing errors.

  1. ../azure-ai-ml>pip install "tox<5"
  2. ../azure-ai-ml>tox run -e next-mypy -c ../../../eng/tox/tox.ini --root .

See the Typing Guide for more information.

@jonaslb
Copy link

jonaslb commented Jan 20, 2025

I realise it's automatic, but this is probably a duplicate. azure-ai-ml has been full-broken (raising on import) in Python 3.13 due to a typing issue, reported around 4 months ago. See #37600

I guess it's nice that there is some kind of automatic testing after all, but clearly 3.13 is missing from the test matrix.

@kristapratico kristapratico added the Service Attention Workflow: This issue is responsible by Azure service team. label Jan 21, 2025
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-ml-sdk @azureml-github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Machine Learning mypy Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants