Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundry v12 warning for using globalThis.mergeObject #545

Open
CommanderTso opened this issue Jul 18, 2024 · 2 comments
Open

Foundry v12 warning for using globalThis.mergeObject #545

CommanderTso opened this issue Jul 18, 2024 · 2 comments
Milestone

Comments

@CommanderTso
Copy link

Currently in v12, Quench gets depreciation warnings for using globalThis.mergeObject:

Error: You are accessing globalThis.mergeObject which must now be accessed via foundry.utils.mergeObject
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    logCompatibilityWarning foundry-esm.js:4609
    get foundry-esm.js:66469
    get defaultOptions quench-results.ts:47
    Application foundry.js:5481
    QuenchResults quench-results.ts:37
    Quench quench.ts:111
    <anonymous> quench-init.ts:41

Repro steps:

  • Enable Quench in a generated Boilerplate project with no changes (used template.json and not data models, if that matters)
  • Enable running the example tests
  • After running, check the console log.
@Ethaks Ethaks added this to the v0.10 milestone Aug 2, 2024
@nivthefox
Copy link

Just a small bump and query: I can probably fix this with a pull request if you're interested in allowing another contributor aboard. I've been thoroughly enjoying using Quench for my modules and I'd hate to see it fall behind as Foundry progresses.

@Ethaks
Copy link
Owner

Ethaks commented Nov 11, 2024

Just a small bump and query: I can probably fix this with a pull request if you're interested in allowing another contributor aboard. I've been thoroughly enjoying using Quench for my modules and I'd hate to see it fall behind as Foundry progresses.

@nivthefox No worries, Quench isn't falling behind anything. There's a v12 branch in this repo that contains an ApplicationV2 refactor of the UI amongst some other small stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants