Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Remove ItemsHoldr from core EightBittr dependency list #309

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Open
3 tasks done

🛠 Tooling: Remove ItemsHoldr from core EightBittr dependency list #309

JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Labels
area: tooling Builds, infrastructure, packages, and other repository management package: eightbittr package: itemsholdr status: accepting prs Go ahead and send a pull request to resolve this issue! type: cleanup Improving code architecture and/or cleanliness.

Comments

@JoshuaKGoldberg
Copy link
Member

Tooling Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

EightBittr/packages/eightbittr/package.json

Line 18 in 4169164

"itemsholdr": "^0.8.8",

Not all games use ItemsHoldr. ChooseYourFramework doesn't. It shouldn't be always required.

Additional Info

The tutorial docs will probably need to be updated to mention adding it explicitly.

See also: #303. I think all these extra things should be opt-in, really.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Go ahead and send a pull request to resolve this issue! type: cleanup Improving code architecture and/or cleanliness. area: tooling Builds, infrastructure, packages, and other repository management package: eightbittr package: itemsholdr labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Builds, infrastructure, packages, and other repository management package: eightbittr package: itemsholdr status: accepting prs Go ahead and send a pull request to resolve this issue! type: cleanup Improving code architecture and/or cleanliness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg