Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No google ad manager ads appearing anywhere on website #90

Open
wendywoo2018 opened this issue Nov 12, 2018 · 8 comments
Open

No google ad manager ads appearing anywhere on website #90

wendywoo2018 opened this issue Nov 12, 2018 · 8 comments
Labels
Milestone

Comments

@wendywoo2018
Copy link

Site was displaying all our google ads but following a plug-in update 6 days ago they have all disappeared. All the ad units are correct in the widgets.

@benlk
Copy link
Collaborator

benlk commented Nov 12, 2018

Hi Wendy,

Can you send us a screenshot of your SCAMP settings page, screenshots of the widget settings, and your site's URL? If you're not comfortable posting them publicly here, you can send us an email at [email protected].

@wendywoo2018
Copy link
Author

http://www.ni4kids.com
screenshot 2018-11-12 at 16 13 44
screenshot 2018-11-12 at 16 13 09
screenshot 2018-11-12 at 16 12 59

@wendywoo2018
Copy link
Author

I haven't updated our other site scotland4kids.com to newest version 0.3 - its still on 0.2 and ads appearing fine

@wendywoo2018
Copy link
Author

wendywoo2018 commented Nov 12, 2018 via email

@benlk
Copy link
Collaborator

benlk commented Nov 12, 2018

That information is all useful to us; thank you.

If you go to https://ni4kids.com/?google_force_console=1, the Google Publisher Console should appear on your site. In it, there'll be an item for each ad on the page:

screen shot 2018-11-12 at 12 29 51 pm

At the very bottom of each item, there's a "Delivery Diagnostics" link. Can you click that for the ni4kids_970x250 ad unit, and tell us what it says? There's additional details about this process at https://support.google.com/admanager/answer/7066157 and https://support.google.com/admanager/answer/7449957, but what we're looking for is any information from Google about the "Ad unit failed to fetch" message provided in the google console.

While we work on fixing this problem, you can download the previous version of this plugin, 0.2.1, from the drop-down at the bottom of https://wordpress.org/plugins/doubleclick-for-wp/advanced/


The following notes in this ticket are for our records, so we can continue debugging if you decide to revert to the earlier version of the plugin.

For the ni4kids_970x250 ad slot you provided the screenshot for, the corresponding entry in the mappings array on window.dfw is mappings1, which has the following contents:

        "mapping1": [{
            "browser": [0, 1],
            "ad_sizes": [
                [320, 50]
            ]
        }, {
            "browser": [480, 1],
            "ad_sizes": [
                [728, 90]
            ]
        }, {
            "browser": [768, 1],
            "ad_sizes": [
                [970, 250],
                [970, 90],
                [728, 90]
            ]
        }],

That matches the screenshot.

For the ni4Kids_HalfPage ad unit, it's mapping2:

        "mapping2": [{
            "browser": [0, 1],
            "ad_sizes": [
                [300, 600]
            ]
        }, {
            "browser": [480, 1],
            "ad_sizes": [
                [300, 600]
            ]
        }, {
            "browser": [768, 1],
            "ad_sizes": [
                [300, 600]
            ]
        }],

That also matches the screenshot.

The full `window.dfw` ```js var dfw = { "dfpID": "12503408", "network_code": "12503408", "mappings": { "mapping1": [{ "browser": [0, 1], "ad_sizes": [ [320, 50] ] }, { "browser": [480, 1], "ad_sizes": [ [728, 90] ] }, { "browser": [768, 1], "ad_sizes": [ [970, 250], [970, 90], [728, 90] ] }], "mapping2": [{ "browser": [0, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 600] ] }], "mapping3": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping4": [{ "browser": [0, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 600] ] }], "mapping5": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping6": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping7": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping8": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping9": [{ "browser": [0, 1], "ad_sizes": [ [320, 50] ] }, { "browser": [480, 1], "ad_sizes": [ [728, 90] ] }, { "browser": [768, 1], "ad_sizes": [ [728, 90] ] }] }, "targeting": { "Page": ["front-page"] } }; ```

@wendywoo2018
Copy link
Author

I reinstalled 0.2.1 but it won’t let me activate and not appearing in settings

@benlk
Copy link
Collaborator

benlk commented Nov 12, 2018

That's disturbing. If you copy the plugin from the functional site to the broken site, does that work?

@benlk
Copy link
Collaborator

benlk commented Nov 16, 2018

(she said yes, in a helpscout email.)

But someone else has reported this, not using the widget but using the $doubleclick->place_ad() function inheriting from global $doubleclick, which used global $DoubleClick before 0.3.

Here's the difference in the page output, using a testing site:

499,502c499
< 	<div
< 				class='dfw-unit'
< 					data-adunit='ET_SideBox'
< 					data-size-mapping='mapping1'></div></aside>
---
> 	<div class='dfw-unit' data-adunit='ET_SideBox' data-size-mapping='mapping1'></div></aside>
640c637
< <link rel='stylesheet' id='dfp-css'  href='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/css/dfp.css?ver=0.2.0' type='text/css' media='all' />
---
> <link rel='stylesheet' id='dfp-css'  href='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/css/dfp.css?ver=0.3.0' type='text/css' media='all' />
653c650
< <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/vendor/jquery.dfp.js/jquery.dfp.min.js?ver=0.2.0'></script>
---
> <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/vendor/jquery.dfp.js/jquery.dfp.min.js?ver=0.3.0'></script>
656c653
< var dfw = {"networkCode":null,"mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
---
> var dfw = {"dfpID":"1234567","network_code":"1234567","mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
659c656
< <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/jquery.dfw.js?ver=0.2.0'></script>
---
> <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/jquery.dfw.js?ver=0.3.0'></script>
661,665c658
< 				jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp({
< 					dfpID: '1234567',
< 					collapseEmptyDivs: false,
< 					setTargeting: {"Page":["home","front-page"]},
< 					sizeMapping: {"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]}				});
---
> 				jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp( window.dfw );

Removing the differences that are pure version number:

499,502c499
< 	<div
< 				class='dfw-unit'
< 					data-adunit='ET_SideBox'
< 					data-size-mapping='mapping1'></div></aside>
---
> 	<div class='dfw-unit' data-adunit='ET_SideBox' data-size-mapping='mapping1'></div></aside>
656c653
< var dfw = {"networkCode":null,"mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
---
> var dfw = {"dfpID":"1234567","network_code":"1234567","mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
661,665c658
< 				jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp({
< 					dfpID: '1234567',
< 					collapseEmptyDivs: false,
< 					setTargeting: {"Page":["home","front-page"]},
< 					sizeMapping: {"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]}				});
---
> 				jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp( window.dfw );

And there's not a significant difference there, so what's going on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants