Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Apache ECharts and dependencies #355

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update Apache ECharts and dependencies #355

wants to merge 11 commits into from

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Jan 20, 2025 •
edited
Loading

Resolves: #353

@vitPinchuk vitPinchuk self-assigned this Jan 20, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.56%. Comparing base (41294c2) to head (1e0324b).

Files with missing lines Patch % Lines
src/components/EchartsPanel/EchartsPanel.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   98.67%   98.56%   -0.12%     
==========================================
  Files          58       58              
  Lines         832      834       +2     
  Branches      138      132       -6     
==========================================
+ Hits          821      822       +1     
- Misses         11       12       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl self-requested a review January 20, 2025 21:42
@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 20, 2025
@mikhail-vl mikhail-vl added this to the Charts 7.0.0 milestone Jan 20, 2025
mikhail-vl
mikhail-vl reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitPinchuk Please fix CI tests.

asimonok
asimonok approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl Awaiting requested review from mikhail-vl

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Status: Ready
Milestone
Charts 7.0.0
Development

Successfully merging this pull request may close these issues.

Update to Apache ECharts 5.6.0
3 participants
@vitPinchuk @asimonok @mikhail-vl