Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume #10265

Draft
wants to merge 1 commit into
base: 4.19
Choose a base branch
from
Draft

[UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume #10265

wants to merge 1 commit into from

Conversation

sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Jan 24, 2025 •
edited
Loading

Description

This PR allows quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume, addresses #10106.

Changes from ui/src/views/storage/TakeSnapshot.vue were removed in #7873, re-added in this PR. Now, ui/src/views/compute/CreateSnapshotWizard.vue and ui/src/views/storage/TakeSnapshot.vue are in sync with respect to quiescevm and asyncbackup flags.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Checked the create snapshot UI from instance and volume.

How did you try to break this feature and the system with this change?

@sureshanaparti
[UI] Allow quiescevm and asyncbackup flags while taking volume snapsh…
4b79dc3 
…ot from UI when these are supported for the volume
@sureshanaparti sureshanaparti linked an issue Jan 24, 2025 that may be closed by this pull request
Quiesce Instance not an option in "Take Instance volume Snapshot" window #10106
Open
@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (2aa2e92) to head (4b79dc3).
Report is 2 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10265   +/-   ##
=========================================
  Coverage     15.14%   15.14%           
  Complexity    11283    11283           
=========================================
  Files          5408     5408           
  Lines        473822   473823    +1     
  Branches      57825    57824    -1     
=========================================
+ Hits          71762    71763    +1     
  Misses       394037   394037           
  Partials       8023     8023
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10265 (QA-JID-531)

@sureshanaparti sureshanaparti mentioned this pull request Jan 24, 2025
Open
DaanHoogland
DaanHoogland approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@Rubueno , any chance you can test this?

@Rubueno
Copy link
Contributor

Rubueno commented Jan 24, 2025

@Rubueno , any chance you can test this?

Thanks for your efforts @DaanHoogland ! I'm abroad right now, but I'll try to find time next week.

@DaanHoogland
Copy link
Contributor

@Rubueno , any chance you can test this?

Thanks for your efforts @DaanHoogland ! I'm abroad right now, but I'll try to find time next week.

have a good trip @Rubueno , I hope to start on a release by the end of next week, no pressure ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 Awaiting requested review from vishesh92

Assignees
No one assigned
Labels
component:UI status:needs-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quiesce Instance not an option in "Take Instance volume Snapshot" window
4 participants
@sureshanaparti @blueorangutan @DaanHoogland @Rubueno