Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Support Spark legacy date formatter whether the spark.sql.legacy.timeParserPolicy is set to LEGACY or legacy. #8581

Closed
weixiuli opened this issue Jan 21, 2025 · 2 comments · Fixed by #8583
Labels
bug Something isn't working triage

Comments

@weixiuli
Copy link
Contributor

weixiuli commented Jan 21, 2025

Backend

VL (Velox)

Bug description

The #7375 has enabled Velox simple date time formatter if the spark.sql.legacy.timeParserPolicy is set to LEGACY. But, it doesn't work when the spark.sql.legacy.timeParserPolicy is set to legacy.

Spark version

3.5.1

Spark configurations

No response

System information

Gluten Version: 1.4.0-SNAPSHOT
Commit: c8284e5
CMake Version: 3.28.3
System: Darwin-23.6.0
Arch: arm64
CPU Name:
C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++
C++ Compiler Version: 16.0.0.16000026
C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc
C Compiler Version: 16.0.0.16000026
CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX15.2.sdk/usr;/opt/homebrew;/usr/local;/usr;/;/opt/homebrew/Cellar/cmake/3.28.3;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local

Relevant logs

@PHILO-HE
Copy link
Contributor

@weixiuli, did you confirm that the lower case is supported by Spark?

@weixiuli
Copy link
Contributor Author

weixiuli commented Jan 22, 2025

did you confirm that the lower case is supported by Spark?

Yes. The pr's unittests can cover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
2 participants