Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage comments #12

Open
b4mboo opened this issue Dec 14, 2011 · 3 comments
Open

manage comments #12

b4mboo opened this issue Dec 14, 2011 · 3 comments

Comments

@b4mboo
Copy link
Owner

b4mboo commented Dec 14, 2011

Enable the user to display existing comments and add new ones.

@b4mboo
Copy link
Owner Author

b4mboo commented Dec 16, 2011

I edited a couple of minor things and renamed the command to simply 'discussion', as I thought it was too long otherwise. I also added output for additional commits. However, this is not complete yet, as I think it would be nice to have all commit messages in there (including the initial one, which is missing at the moment). At some point I'd like to merge this command into 'show', such that the user has all relevant information at once.

The only thing missing to close this issue is a command 'comment' that takes the ID and a string to create a new comment. I was thinking of sth. like this:
git review comment 42 -m 'new comment'
or a prompt if the -m is missing ("Please enter your comment:").

@b4mboo
Copy link
Owner Author

b4mboo commented Dec 19, 2011

OK, I merged discussion into 'show', since I don't think there are real use cases for having it a separate command. Also, 'show' really gives a very good overview about what's happening.

@b4mboo
Copy link
Owner Author

b4mboo commented Feb 9, 2012

I added the command 'approve' that basically just adds a comment. Eventually, some refactoring will help to close this issue here, too, by just using the already present code. Assigning myself to the task.

@ghost ghost assigned b4mboo Feb 9, 2012
xystushi added a commit that referenced this issue Sep 10, 2014
Small amendments to your PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants