Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify immutability invariants for StarlarkList/Dict constructors #24851

Open
brandjon opened this issue Jan 7, 2025 · 0 comments
Open

Clarify immutability invariants for StarlarkList/Dict constructors #24851

brandjon opened this issue Jan 7, 2025 · 0 comments
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob type: bug

Comments

@brandjon
Copy link
Member

brandjon commented Jan 7, 2025

For example, does creating a dict with a frozen mutability imply that its contents are also deeply frozen? This seems to be our assumption, but if so, the javadoc needs updating to stress this point as a possible API foot-gun. Same with StarlarkList construction.
@brandjon brandjon added type: bug P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandjon