Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links at footer of page (Terms | Privacy | Notices) #995

Open
bduranc opened this issue Aug 16, 2022 · 7 comments
Open

Broken links at footer of page (Terms | Privacy | Notices) #995

bduranc opened this issue Aug 16, 2022 · 7 comments

Comments

@bduranc
Copy link

bduranc commented Aug 16, 2022

Issue Type: Bug
Issue Description:

The site's footer shows three hyper links: Terms | Privacy | Notices. All of these lead the user to clearlydefined.io (current homepage).

Capture

I'm unsure which of these content areas have been built out, but I do remember some areas being available under the docs:

https://docs.clearlydefined.io/legal/terms
https://docs.clearlydefined.io/legal/privacy

I think we should update these footer links so the user is redirected to the respective areas

@bduranc
Copy link
Author

bduranc commented Aug 16, 2022

The appropriate areas appear commented out, but do exist on the docs site: https://github.com/clearlydefined/website/blob/930f0b501d106d182ec56a85f32c913345944dc2/src/components/Footer.js

(the NOTICES probably need regeneration since the site was updated, have not checked if it was already or not)

@lumenCodes
Copy link

Hi, @bduranc so if I understand the issue here is to remove the comments and also update the link to the locations.

@bduranc
Copy link
Author

bduranc commented Sep 17, 2022

@lumenCodes yes that is correct.
The main issue is that these footer links don't work when we know they should:

Terms: https://docs.clearlydefined.io/legal/terms
Privacy: https://docs.clearlydefined.io/legal/privacy
Notices: https://docs.clearlydefined.io/legal/NOTICES

@lumenCodes
Copy link

Thank you for your response, I think this is a good first issue so I will bring a first time contributor to try this out.

The issue will then be assigned to the person 🙂

@bduranc
Copy link
Author

bduranc commented Sep 19, 2022

Great, thanks @lumenCodes.

@qtomlinson @mpcen : FYI

@ACAnyasodor
Copy link

hi @bduranc i fully understand the issues, can i take it up?

@qtomlinson
Copy link
Collaborator

See https://docs.clearlydefined.io/contributing-code as a guideline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants