Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--replace does not use sane indentation #189

Open
jmromrell opened this issue May 8, 2017 · 2 comments
Open

--replace does not use sane indentation #189

jmromrell opened this issue May 8, 2017 · 2 comments

Comments

@jmromrell
Copy link

Currently, when kibit automatically makes multi-line changes, it will put the result on one very long line.

It would be great if it could do a bit of basic formatting. Even naive formatting would be easier to read and result in less manual work than none at all.

@arrdem
Copy link
Collaborator

arrdem commented May 9, 2017

My $0.02 on this is that kibit is not a formatter, it's a simplifier / linter. The new --replace option is a very alpha feature for supporting automatic simplification. Other tools such as cljfmt and sjacket are simply far better at (read; designed for) code formatting whereas kibit is not.

@jmromrell
Copy link
Author

I'd agree with you, except kibit already formats suggested changes using pprint. I looked over the source earlier, and it looks as though the replace code should be utilizing pprint as well, so I'm not exactly sure why it wasn't formatting for me, but it does appear to be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants