Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithBaseCall will ommit second parameter with same type due to Dictionary usage #53

Open
vmachacek opened this issue Apr 11, 2023 · 2 comments

Comments

@vmachacek
Copy link
Contributor

I'm not sure if I'm doing something crazy but I have this code

.AddConstructor(Accessibility.Public).WithBaseCall(new Dictionary<string, string>()
{
    ["IPage"] = "page",
    ["string"] = "absolutePath",
    ["string"] = "elementPath",
})

which will result in

 public FooBar(IPage page, string elementPath)
            : base(page, elementPath)
        {
            Page = page;
        }

because Dictionary is used the third param will overwrite the second. How can I add two params of same type?

@dansiegel
Copy link
Owner

I'd say this seems like an oversight and a bug.

@vmachacek
Copy link
Contributor Author

i made this PR #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants