Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in collectors fail promtool linting #135

Open
mpalmer opened this issue Sep 22, 2021 · 0 comments
Open

Built-in collectors fail promtool linting #135

mpalmer opened this issue Sep 22, 2021 · 0 comments

Comments

@mpalmer
Copy link

mpalmer commented Sep 22, 2021

With a stock install of prometheus.ex exporting the default Erlang metrics, the following linting failures are reported:

$ wget -O - -q http://localhost:9548/metrics | promtool check metrics
erlang_vm_statistics_context_switches counter metrics should have "_total" suffix
erlang_vm_statistics_garbage_collection_bytes_reclaimed counter metrics should have "_total" suffix
erlang_vm_memory_atom_bytes_total non-counter metrics should not have "_total" suffix
erlang_vm_statistics_garbage_collection_number_of_gcs counter metrics should have "_total" suffix
erlang_vm_statistics_garbage_collection_words_reclaimed counter metrics should have "_total" suffix
erlang_vm_statistics_runtime_milliseconds counter metrics should have "_total" suffix
erlang_vm_statistics_wallclock_time_milliseconds counter metrics should have "_total" suffix
erlang_vm_memory_bytes_total non-counter metrics should not have "_total" suffix
erlang_vm_memory_processes_bytes_total non-counter metrics should not have "_total" suffix
erlang_vm_memory_system_bytes_total non-counter metrics should not have "_total" suffix
erlang_vm_statistics_run_queues_length_total non-counter metrics should not have "_total" suffix
erlang_vm_atom_count non-histogram and non-summary metrics should not have "_count" suffix
erlang_vm_port_count non-histogram and non-summary metrics should not have "_count" suffix
erlang_vm_process_count non-histogram and non-summary metrics should not have "_count" suffix
erlang_vm_statistics_runtime_milliseconds use base unit "seconds" instead of "milliseconds"
erlang_vm_statistics_wallclock_time_milliseconds use base unit "seconds" instead of "milliseconds"

Allowing people to adjust their base units if they like is nice, but IMAO the out-of-the-box defaults should be promtool compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant