Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading quantile summary metrics fails intermittently when no labels are used #146

Open
Scott2e opened this issue Oct 14, 2022 · 0 comments

Comments

@Scott2e
Copy link

Scott2e commented Oct 14, 2022

For the life of me I can't reproduce this in dev and uat, it only seems to fail when run in prod (where this library is getting used more heavily), and not all the time which is weird. This issue seems to occur only when labels haven't been used for quantile summary metrics.

** (exit) an exception was raised:
    ** (MatchError) no match of right hand side value: true
        (quantile_estimator 0.2.1) /quantile_estimator/src/quantile_estimator.erl:141: :quantile_estimator.merge/2
        (quantile_estimator 0.2.1) /quantile_estimator/src/quantile_estimator.erl:133: :quantile_estimator.compress/4
        (quantile_estimator 0.2.1) /quantile_estimator/src/quantile_estimator.erl:133: :quantile_estimator.compress/4
        (quantile_estimator 0.2.1) /quantile_estimator/src/quantile_estimator.erl:106: :quantile_estimator.compress/1
        (prometheus 4.9.1) src/metrics/prometheus_quantile_summary.erl:354: anonymous fn/3 in :prometheus_quantile_summary.collect_metrics/2
        (stdlib 3.16.1) lists.erl:1267: :lists.foldl/3
        (prometheus 4.9.1) src/metrics/prometheus_quantile_summary.erl:348: :prometheus_quantile_summary.collect_metrics/2
        (prometheus 4.9.1) src/model/prometheus_model_helpers.erl:131: :prometheus_model_helpers.create_mf/5

Sorry I can't be more helpful with this. I did take a look through prometheus_quantile_summary.erl but my inability to read Erlang code is letting me down.. A failing of mine I wish to correct at some point..

@Scott2e Scott2e changed the title Reading quantile summary metrics when no labels are used intermittently fails Reading quantile summary metrics fails intermittently when no labels are used Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant