Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream quantile_estimator? #163

Open
kivra-pauoli opened this issue Mar 8, 2024 · 5 comments
Open

Use upstream quantile_estimator? #163

kivra-pauoli opened this issue Mar 8, 2024 · 5 comments

Comments

@kivra-pauoli
Copy link

👋, @deadtrickster.

First of all, great work on this lib.

Recently, while compiling with OTP 26, we started seeing some quantile_estimator -related issues:

  • float format -related
  • auto-import -related

Since https://github.com/deadtrickster/quantile_estimator is an (outdated) fork of https://github.com/odo/quantile_estimator (and implements no novelty on top of it) I wonder if you'd be open to start using that version, instead of your fork?

Maybe @odo and you can even come to an agreement in sharing publishing rights for the lib. in Hex (it seems the one published there is the fork, not the upstream) and it'd help maintenance for us consumers, since:

  • it's less confusing of a setup
  • it's a single place to update and would prevent some workaround like overriding rebar3 options for what was mentioned above.

Thanks for taking this into consideration.

@kivra-pauoli
Copy link
Author

As per a more recent issue we faced, this would also solve using https://github.com/voltone/rebar3_sbom on quantile_estimator, pulled by this library, to identify the license as "MIT" instead of "N/A": https://github.com/odo/quantile_estimator/blob/master/src/quantile_estimator.app.src#L5.

Is there anything I can do to help move this process forward?

@essen
Copy link
Collaborator

essen commented May 21, 2024

@ikavgo

@ikavgo
Copy link
Collaborator

ikavgo commented May 21, 2024

hello, how I add @odo to hex package?

@kivra-pauoli
Copy link
Author

kivra-pauoli commented May 21, 2024

Lemme check. I've done this in the past, but don't remember the details by heart.

Edit

Using the hex plugin for rebar3:

rebar3 hex owner add -r <repo> <package> <username>

I'm not sure what the <username> is since I don't think it's possible to search Hex.pm by user.
<package> should be quantile_estimator.
<repo> I'm not sure it's the GitHub one or Hex.pm one.

Thanks for looking into this.

@odo
Copy link

odo commented Jun 27, 2024

Happy to share the rights and make the package more compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants