You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Deno does not report the creation of the symlink because it runs a prefix check along the lines of event.path.startsWith(watchedPath). But event.path is canonicalized to /tmp/some-file, causing the event to be ignored because "it did not occur in the watched path".
This bug causes events in /dev/disk/by-id to be ignored because all files in there are symlinks to other paths in /dev/.
inotifywait reports CREATE, MOVED_FROM, MOVED_TO events in /dev/disk/by-id/ while deno reports remove
Relates to #27559
At least one of these issues is a regression that occurred late in deno 1 or with the switch to deno 2.
Solving #27559 might be enough. My devices trigger too many events to tell quickly if this current issue is actually causing problems.
@littledivy#26200 added the is_same_file() || starts_with_canonicalized() check which breaks for symlinks. In the commit message and PR I can't find why we need this check, and all tests pass when I remove it. Do you remember what we need the check for and if it'd be possible to write a test case for it?
Version: Deno 2.1.4
ln -s /tmp/some-file /tmp/test/
Deno does not report the creation of the symlink because it runs a prefix check along the lines of
event.path.startsWith(watchedPath)
. Butevent.path
is canonicalized to/tmp/some-file
, causing the event to be ignored because "it did not occur in the watched path".This bug causes events in
/dev/disk/by-id
to be ignored because all files in there are symlinks to other paths in/dev/
.inotifywait
reportsCREATE
,MOVED_FROM
,MOVED_TO
events in/dev/disk/by-id/
while deno reportsremove
Relates to #27559
At least one of these issues is a regression that occurred late in deno 1 or with the switch to deno 2.
Solving #27559 might be enough. My devices trigger too many events to tell quickly if this current issue is actually causing problems.
Related source
deno/runtime/ops/fs_events.rs
Line 156 in 7cabd02
The text was updated successfully, but these errors were encountered: