You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ticket is understood, and QA has been contacted (if the ticket has a QA label).
User Story(ies)
As a Notify stakeholder, I want to use the most up to date Python pyjwt package So that we don't have bit rot or vulnerabilities.
Additional Info and Resources
During the routine upgrades for #2103, upgrading pyjwt from 2.9.0 to 2.10.0 caused 80 test failures in Github that probably all result from an unannounced breaking change. The tests did not fail locally for the person who did the upgrade. 🤷
Traced source of error for tests in tests/app/authentication/test_authentication.py
Method requires_user_in_service_or_admin passed in None for arg required_permission. This results in error when calling validate()
This only seems to be an issue when called the decorator requires_user_in_service_or_admin. requires_user_in_service_or_admin called in code passes in required_permission='manage_templates'. See app/template/rest.py::245.
User Story - Business Need
User Story(ies)
As a Notify stakeholder,
I want to use the most up to date Python pyjwt package
So that we don't have bit rot or vulnerabilities.
Additional Info and Resources
During the routine upgrades for #2103, upgrading pyjwt from 2.9.0 to 2.10.0 caused 80 test failures in Github that probably all result from an unannounced breaking change. The tests did not fail locally for the person who did the upgrade. 🤷
Comment to bypass this.
Acceptance Criteria
Makefile removes the 74429 ignore and associated commentThis was in PR @k-macmillan was working on and not merged into main.QA Considerations
Potential Dependencies
The text was updated successfully, but these errors were encountered: