Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor suggestions about images #100

Open
azimut opened this issue Mar 11, 2017 · 2 comments
Open

minor suggestions about images #100

azimut opened this issue Mar 11, 2017 · 2 comments

Comments

@azimut
Copy link
Contributor

azimut commented Mar 11, 2017

Some ideas I got working with containers and might be consider here. If not valid here feel free to close this.

  • about nginx-php, might be this image can be de-coupled, and have one image for php-fpm and other for nginx. The official docker images for wordpress took this approach. Which also follows the pattern of having only one binary running per container. Additionally share the same fs could be a vector of attack (if permissions are too permissive) https://blog.tarq.io/root-your-box-with-w3tc-and-nginx/ Although this brings some extra volume linking needed between then.
  • about postgres, the entrypoint script is posix so in theory it doesn't need bash
@jbergstroem
Copy link
Contributor

@azimut the idea is that you create your own containers -- see the bundled ones as examples!

@edannenberg
Copy link
Owner

@jbergstroem Agreed, but on the other hand the example images should be best practice, so general improvements should always be welcome.

@azimut I'll fix the postgres script but I don't really have the time for the nginx-php refactor at the moment, will happily accept a PR though.

edannenberg added a commit that referenced this issue Mar 26, 2017
* Fix code to satisfy shellcheck, setup travis ci #104
* Improve download/container error handling #109
* Fix postgres run script shebang #100
* Use memcache-1.4.33-r1, see #99
* Improve interactive build container usage #96
* Update templates documentation
* Replace deprecated LABEL tag in docker files
* Update all image build configs/docs. Fix some minor regressions
* Fix cross-namespace builder regression, the default builder was always used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants