Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIRROR fails with multiple elements #250

Open
ctr49 opened this issue Feb 13, 2024 · 2 comments
Open

MIRROR fails with multiple elements #250

ctr49 opened this issue Feb 13, 2024 · 2 comments

Comments

@ctr49
Copy link

ctr49 commented Feb 13, 2024

kubler.conf describes MIRROR with

# Download location for stage3 and Portage files, use whitespace to set multiple servers
# You may visit https://www.gentoo.org/downloads/mirrors/ and pick a http or ftp url near your physical location
MIRROR='http://distfiles.gentoo.org/'

So multiple mirrors should be allowed.

However, the ARCH_URL construction in core.sh uses the entire string, failing if it contains multiple mirrors.

I think the solution is to treat MIRROR as a set and cast it into an array, using one (the first?) of the MIRROR elements for ARCH_URL (and any future usages of MIRROR).

Doing this, it would also be useful to force or strip a trailing slash in the mirror URL and build ARCH_URL accordingly (it currently breaks when there is no trailing slash).

@edannenberg
Copy link
Owner

Thanks for reporting! I added some extra handling that should resolve both issues.

@berney
Copy link
Contributor

berney commented Jan 5, 2025

I think this is resolved and can be closed @edannenberg @ctr49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants