GH-19 clarified leading slash in the spec #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mipo256
changed the title
|
I think this is good clarification, but we still need to ensure our tests have covered this case |
cxw42
requested changes
Jan 24, 2025
There was a problem hiding this comment.
@mipo256 thanks for the PR! Have you run modified core tests covering this case, as suggested by @xuhdev ? If you could open a corresponding PR in https://github.com/editorconfig/editorconfig-core-test , that would add confidence in this change.
Other than testing, I have one request for a modification to the text.
| level. For example, ``*.c`` matches any file that ends with ``.c`` in the | ||
| level. | ||
|
|
||
| Therefore, similar to a `gitignore format`_, a leading slash is not relevant if there is already a slash in the middle of the pattern. |
There was a problem hiding this comment.
I don't think we should mention gitignore here, lest people think that editorconfig files have the same semantics as gitignore files.
Suggested change
| Therefore, similar to a `gitignore format`_, a leading slash is not relevant if there is already a slash in the middle of the pattern. | |
| Therefore, a leading slash is not relevant if there is already a slash in the middle of the pattern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19
📚 Documentation preview 📚: https://editorconfig-specification--68.org.readthedocs.build/