Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pretty-quick to tinyexec #85

Open
43081j opened this issue Aug 19, 2024 · 1 comment
Open

Migrate pretty-quick to tinyexec #85

43081j opened this issue Aug 19, 2024 · 1 comment
Labels
has pr This issue has a corresponding PR in the target repo needs first contact It is unclear if the maintainer of the repo is open for e18e

Comments

@43081j
Copy link
Collaborator

43081j commented Aug 19, 2024

pretty-quick currently uses execa:

https://github.com/prettier/pretty-quick/blob/b5e00ba235a246bc087e3b800ef96916f2e05684/src/scms/git.ts#L47-L49

this can be replaced with tinyexec, a lighter alternative.

all usages are basic, so this should be an easy migration
@pralkarz
Copy link

pralkarz commented Sep 4, 2024 •
edited
Loading

Submitted a PR in the upstream (prettier/pretty-quick#195).

@Fuzzyma Fuzzyma added needs first contact It is unclear if the maintainer of the repo is open for e18e has pr This issue has a corresponding PR in the target repo labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has pr This issue has a corresponding PR in the target repo needs first contact It is unclear if the maintainer of the repo is open for e18e
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fuzzyma @43081j @pralkarz