Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add test for "must not exceed the maximum of 4 weeks" #2832

Open
pquerner opened this issue Jan 15, 2025 · 1 comment
Open

[FR] Add test for "must not exceed the maximum of 4 weeks" #2832

pquerner opened this issue Jan 15, 2025 · 1 comment

Comments

@pquerner
Copy link

Is your feature request related to a problem? Please describe.
When inserting a pushnotification, its TTL may not exceed 4 weeks according to docs.
This is only checked after the request is send to the API. It should be checked in the library, to easier catch bugs and not annoy the API.

Describe the solution you'd like
Check the payload TTL locally (in the library) for common mistakes.

Describe alternatives you've considered
Right now its done to the enduser of checking this. And the results may vary. In the end it can happend due to bugs or other things that invalid payloads still get send to the API - when this library could've prevented that.

Thanks for consideration.

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants