Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclusion of the tests in CLI #1512

Open
Arcticae opened this issue Jan 10, 2024 · 4 comments · May be fixed by #2361
Open

Add exclusion of the tests in CLI #1512

Arcticae opened this issue Jan 10, 2024 · 4 comments · May be fixed by #2361
Assignees
@cptartur
Labels
feature New feature request/description help wanted snforge

Comments

@Arcticae
Copy link
Contributor

Arcticae commented Jan 10, 2024 •
edited
Loading

Which components does the task require to be changed?

snforge

Description

We should add a regex which would make it able to exclude certain file/path/test name patterns

We should also investigate how other tools approach this
@Arcticae Arcticae added the feature New feature request/description label Jan 10, 2024
@github-actions github-actions bot added the new label Jan 10, 2024
@Arcticae Arcticae changed the title Add filtering out the tests feature Add filtering out the tests in CLI Jan 10, 2024
@Arcticae Arcticae removed the new label Jan 15, 2024
@Arcticae Arcticae moved this from Triage to Backlog in Starknet foundry Jan 15, 2024
@Arcticae Arcticae changed the title Add filtering out the tests in CLI Add exclusion of the tests in CLI Jan 15, 2024
@Arcticae Arcticae moved this from Backlog to TODO in Starknet foundry Jan 15, 2024
@Arcticae Arcticae moved this from TODO to Backlog in Starknet foundry Jan 25, 2024
@Arcticae Arcticae moved this from Backlog to Triage in Starknet foundry May 22, 2024
@julienbrs
Copy link

Hey!
I'd like to work on it please

@Arcticae
Copy link
Contributor Author

Arcticae commented Aug 7, 2024

@julienbrs feel free to submit a PR (or propose changes in a comment so we can give you some tips before you work on this)

@julienbrs
Copy link

Will submit a PR tomorrow

@julienbrs julienbrs linked a pull request Aug 9, 2024 that will close this issue
Open
5 tasks
@julienbrs
Copy link

cc @Arcticae PR opened, would be awesome to have any thoughts on it

@cptartur cptartur self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cptartur cptartur

Labels
feature New feature request/description help wanted snforge
Projects
Starknet foundry
Status: TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat add exclude pattern running tests julienbrs/starknet-foundry
3 participants
@Arcticae @cptartur @julienbrs