Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for -Z asm-comments #58

Open
GabrielMajeri opened this issue Sep 6, 2018 · 1 comment
Open

Support for -Z asm-comments #58

GabrielMajeri opened this issue Sep 6, 2018 · 1 comment

Comments

@GabrielMajeri
Copy link

GabrielMajeri commented Sep 6, 2018

A recent rust-lang PR added support for LLVM assembly comment output. While only available on nightly, it would be great if cargo asm could support them.

Currently, the following commands don't work:

$ RUSTFLAGS="-Z asm-comments" cargo asm
thread 'main' panicked at 'line starts with _ but we failed to parse the label: ...
@gnzlbg
Copy link
Owner

gnzlbg commented Sep 6, 2018

Yep, I've asked if there are any plans to stabilize that flag but there aren't any already so this won't work with the stable Rust compilers for the time being. We can detect if the compiler is a nightly compiler, and pass it the flag if that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants