Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temporary file deletion not working on Windows #82

Open
makuto opened this issue May 10, 2022 · 0 comments
Open

Fix temporary file deletion not working on Windows #82

makuto opened this issue May 10, 2022 · 0 comments

Comments

@makuto
Copy link

makuto commented May 10, 2022

See this issue.

The Windows version of codesearch is broken because it doesn't properly close any of its file handles before it tries to remove the files.

My fork has this change which fixes this. My fork has diverged (I added a tempDir argument so that I could move the temp files where I wanted them), but someone should be able to port over my changes without too much issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant