From 1a8ca769828b3c9400572132b7ba2eccce0cd2cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jordi=20Guti=C3=A9rrez=20Hermoso?= <jordigh@octave.org>
Date: Wed, 8 Jan 2025 19:39:49 -0500
Subject: [PATCH] worfklows: update upload-artifacts version

v3 of `upload-artifacts` will soon error out, so we need to migrate to v4.
---
 .github/workflows/main.yml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index bbe56552e8..77925d7363 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -163,7 +163,6 @@ jobs:
           TESTDIR: ${{ runner.temp }}/test-logs
 
       - name: Prepare for saving artifact
-        if: failure()
         run: |
           ARTIFACT_NAME=logs-$(echo $TESTS | sed 's/[^-a-zA-Z0-9]/_/g')
           echo "Artifact name is '$ARTIFACT_NAME'"
@@ -175,8 +174,7 @@ jobs:
           TESTDIR: ${{ runner.temp }}/test-logs
 
       - name: Save artifacts on failure
-        if: failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ env.ARTIFACT_NAME }}
           path: ${{ runner.temp }}/test-logs  # only exists for webdriver tests