-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buggy UI for /merges in mobile #10337
Comments
Hey @Spaarsh are you currently working on this issue, if not, can I work on it? |
CC @seabelis @bitnapper @zorae @mheiman Is this an issue that librarians are hitting that we should tackle? Do you all use the merge queue on mobile? |
I rarely use the merge queue on mobile, but this seems like a pretty easy first task for someone. Having functional mobile views is always a win. |
I’ve never really used the merge queue on a smartphone, so I wouldn’t say that this issue is a priority for me personally. |
I regularly use it on my Phone and Tablet. I prefer my desktop whenever I can but when I'm waiting somewhere and have the time I try to get a bit don. |
Thanks for the feedback, all. @Craig-Rosario
|
Yeah so I understand that the icon blocks the review and overlaps it. Changes need to be made to "merge-request-table.less" file merges._.Open.Library.Mozilla.Firefox.2025-01-23.22-48-52.mp4I have added a video of the solution, do let me know your thoughts on it @jimchamp |
@Craig-Rosario Since we are making these changes, I would suggest that the side-ways scrolling should be prevented from occuring. As a solution, when the user clicks on the icon, the comments should be visible similar to how YouTube comments are seen. This will require javascript changes as well. Additionally, once the icon is clicked, the icon should move to the bottom of the comment box. Could you weight in on this @jimchamp @mheiman @bitnapper @zorae @seabelis? Thanks! |
Problem
When the reviews icon is clicked upon and the reviews are dropped down, the icon itself blocks the right-most content. Attempts to scroll horizontally, the icon itself moves with the content, essentially obfuscating the content to no avail.
Buggy_merge_UI_for_mobile.mp4
Reproducing the bug
Context
Breakdown
Requirements Checklist
Related files
Stakeholders
Instructions for Contributors
The text was updated successfully, but these errors were encountered: