Add post login action - follow #10365
Conversation
| if not redirect_path or "/" not in redirect_path: | ||
| return None | ||
|
|
||
| publisher = redirect_path.split("/")[-1] |
There was a problem hiding this comment.
I don't think we can reliably use the redirect_url to get the publisher and the state as the redirect page may be something like the book page (e.g. /books/OL14587328M -- i.e. the page to send the patron to after the follow is successful).
There was a problem hiding this comment.
I don't think we can reliably use the
redirect_urlto get thepublisherand thestateas the redirect page may be something like the book page (e.g./books/OL14587328M-- i.e. the page to send the patron to after the follow is successful).
Thanks for your input, Mek. I agree with your design choice.
I'll update the PR to retrieve the publisher username from the parameters instead of the redirect URL.
But, could you please clarify what you mean by "state"? In this scenario, the state will always be "follow" since the user is logged out, and the button will always display "follow."
There was a problem hiding this comment.
But, could you please clarify what you mean by "state"? In this scenario, the state will always be "follow" since the user is logged out, and the button will always display "follow."
🤔 yes, good point @ShilpThapak! Maybe we can get away with not requiring an additional state parameter for exactly the reason you describe.
I wonder if maybe to keep things simple we want to try something like
action=follow:<username>? e.g. action=follow:mekBot
We wouldn't have to add any new fields and can easily split the action string on :.
| if PubSub.is_subscribed(subscriber=ol_account.username, publisher=publisher): | ||
| flash_message = "You are already following this user!" | ||
| else: | ||
| PubSub.subscribe(subscriber=ol_account.username, publisher=publisher) |
There was a problem hiding this comment.
It doesn't matter so much if the patron is already following the patron, we can simplify this to
PubSub.subscribe(subscriber=ol_account.username, publisher=publisher) and then f"You are following {publisher}"
There was a problem hiding this comment.
It doesn't matter so much if the patron is already following the patron, we can simplify this to
PubSub.subscribe(subscriber=ol_account.username, publisher=publisher)and thenf"You are following {publisher}"
Makes sense, Mek. Your approach will be better for performance since it will reduce the lookup operation. I'll change this to your code.
I just wanted to point out that the message will say "You are following username" and not "You are following display_name" because we are capturing the username in the parameters.
There was a problem hiding this comment.
That's true -- we could fetch the display_name should we choose to from the web.ctx.site query engine (as is done throughout upstream/accounts and upstream/mybooks, I believe)
There was a problem hiding this comment.
Thank you for this contribution @ShilpThapak! The form and overall structure look good! Take a look at the original example in the issue as there may be some opportunities to simplify the code.
I think beyond (or with) action we need to somehow also capture the publisher and op for the follow case.
mekarpeles
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ShilpThapak
force-pushed
the
10338/feature/post_login_action
branch
from
694da07 to
ed1a2e3
Compare
|
@mekarpeles,
Please take a look at the attached video. pr_update.mp4 |
Closes #10338
This PR is a
featureTechnical
Currently, the website does not allow users to follow a publisher if they are not logged in. After logging in, the user must manually return to the publisher's profile to follow them.
With this PR, the follow operation will be handled by the backend.
Testing
To test this, go to any user profile and try to follow them while logged out. You will be redirected to the login page, and after logging in, the backend will automatically complete the follow operation for you and display a flash message.
Screenshot
Before:
before_ol.mp4
After:
after_no_follow.mp4
Already following:
after_ol.mp4
Stakeholders
@mekarpeles