Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same port for hubble-metrics that is used by cilium #17177

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Use the same port for hubble-metrics that is used by cilium #17177

merged 2 commits into from
Jan 10, 2025
+10 −11

Conversation

kforsthoevel
Copy link
Contributor

Cilium uses port 9965 for hubble-metrics. See https://docs.cilium.io/en/stable/observability/metrics/#hubble-metrics

Fixes #17174

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 7, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @kforsthoevel!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kforsthoevel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added area/addons area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 7, 2025
@hakman
Copy link
Member

hakman commented Jan 7, 2025

/ok-to-test
/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet January 7, 2025 09:06
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2025
@kforsthoevel
Copy link
Contributor Author

/retest

1 similar comment
@kforsthoevel
Copy link
Contributor Author

/retest

@kforsthoevel
Copy link
Contributor Author

@hakman The tests are failing, but I don't understand why. Is there anything I can do here?

@hakman
Copy link
Member

hakman commented Jan 7, 2025

@kforsthoevel Please run hack/update-expected.sh and commit the output. That should fix most tests. The ones with Pod scheduling timeout. error need to be retried. There are some issues with the K8s infra scaling at the moment.

@kforsthoevel
Copy link
Contributor Author

/retest

@hakman
Copy link
Member

hakman commented Jan 7, 2025

/override pull-kops-e2e-cni-flannel

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-flannel

In response to this:

/override pull-kops-e2e-cni-flannel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kforsthoevel
Copy link
Contributor Author

/retest

@hakman
Copy link
Member

hakman commented Jan 7, 2025

Please ignore the flannel test, it will always fail.

@hakman
Copy link
Member

hakman commented Jan 7, 2025

/override pull-kops-e2e-cni-flannel

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-flannel

In response to this:

/override pull-kops-e2e-cni-flannel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Jan 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@hakman
Copy link
Member

hakman commented Jan 10, 2025

Thanks @kforsthoevel
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@hakman
Copy link
Member

hakman commented Jan 10, 2025

/test all

@hakman hakman mentioned this pull request Jan 10, 2025
Merged
@hakman
Copy link
Member

hakman commented Jan 10, 2025

/override pull-kops-e2e-cni-flannel

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-flannel

In response to this:

/override pull-kops-e2e-cni-flannel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2025 •
edited
Loading

@kforsthoevel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons 84ff74c link false /test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Jan 10, 2025

/override pull-kops-e2e-cni-cilium-etcd

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-etcd

In response to this:

/override pull-kops-e2e-cni-cilium-etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 0486349 into kubernetes:master Jan 10, 2025
29 of 30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jan 10, 2025
@kforsthoevel kforsthoevel deleted the fix-hubble-metrics-port branch January 10, 2025 09:33
k8s-ci-robot added a commit that referenced this pull request Jan 10, 2025
@k8s-ci-robot
Merge pull request #17198 from hakman/automated-cherry-pick-of-#17177…
2a0a6f5 
…-upstream-release-1.31

Automated cherry pick of #17177: Use the same port for hubble-metrics that is used by
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

The hubble-metrics port of the cilium DaemonSet is not in sync with the hubble-metrics service
3 participants
@kforsthoevel @k8s-ci-robot @hakman