Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): added unban icon #2738

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(icons): added unban icon #2738

wants to merge 5 commits into from
+35 −0

Conversation

niko-gardenanet
Copy link

closes #2737

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This PR adds the unban icon.

Icon use case

Icon for unblocking/unbanning users

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: ban
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Added or changed icons

icons/unban.svg

Preview cohesion icons/square-arrow-out-up-right.svg
icons/unban.svg
icons/accessibility.svg
Preview stroke widths icons/unban.svg
icons/unban.svg
icons/unban.svg
DPI Preview (24px) icons/unban.svg
Icon X-rays icons/unban.svg
Icon Diffs icons/unban.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const UnbanIcon = createLucideIcon('Unban', [
  ["circle",{"cx":"12","cy":"12","r":"10"}],
  ["path",{"d":"M4.9 4.9 9 9"}],
  ["path",{"d":"M19.1 19.1 15 15"}]
])

karsa-mistmere
karsa-mistmere requested changes Jan 15, 2025
View reviewed changes
icons/unban.svg Outdated Show resolved Hide resolved
icons/unban.json Outdated Show resolved Hide resolved
@jguddas
Copy link
Member

jguddas commented Jan 15, 2025

Feels unusual, do you have an example where this kind of imagery is used for unbanning?

@niko-gardenanet
Copy link
Author

Feels unusual, do you have an example where this kind of imagery is used for unbanning?

Sorry, apparently I used some invalid syntax in the SVG path which was removed by the linter before pushing. Fixed it now

@niko-gardenanet niko-gardenanet changed the title Added unban icon feat(icons): added unban icon Jan 16, 2025
@ericfennis
Copy link
Member

I'm with @jguddas, not sure about this one. I've never seen this. Is there not something more conventional for this?
Maybe the solution for this usecase should be more positive, like "Re-active account" with a variant of a user icon?

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Jan 17, 2025 •
edited
Loading

I'm with @jguddas, not sure about this one. I've never seen this. Is there not something more conventional for this? Maybe the solution for this use case should be more positive, like "Re-active account" with a variant of a user icon?

Yeah, also unsure about whether this representation is globally comprehensible.

Maybe, as in so many cases, the proper solution from a UX point of view would be to simply not use any icons for this, just the texts Ban and Unban. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karsa-mistmere karsa-mistmere Awaiting requested review from karsa-mistmere

Assignees
No one assigned
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unban icon
4 participants
@niko-gardenanet @jguddas @ericfennis @karsa-mistmere