Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Update Request: GitLab #638

Closed
wj25czxj47bu6q opened this issue Apr 28, 2022 · 5 comments
Closed

Icon Update Request: GitLab #638

wj25czxj47bu6q opened this issue Apr 28, 2022 · 5 comments

Comments

@wj25czxj47bu6q
Copy link

As of yesterday, GitLab changed their logo. As such, the GitLab icon no longer matches GitLab's logo.

Since this is an existing deprecated brand icon, I am not sure of Lucide's official stance on updating it. My personal opinion is that the icon should be deleted if the official stance is to reject the update.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented May 2, 2022

Damn, and I've just fixed this too. A new version would be:
image

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M21.8 13.1a4.36 4.36 0 0 0-.14-3l-2.73-6.68a.72.72 0 0 0-.7-.42.73.73 0 0 0-.66.49L15.52 9h-7l-2.1-5.51a.74.74 0 0 0-1.36-.07l-2.72 6.71a4.36 4.36 0 0 0-.14 3A4.71 4.71 0 0 0 4 15.58l4.17 2.89 3.3 2.37A.94.94 0 0 0 12 21a.87.87 0 0 0 .5-.15l3.32-2.38L20 15.56a4.56 4.56 0 0 0 1.8-2.46Z" />
</svg>

I'll let others decide what to do with this one, as per #94 this redesign might be needed for a separate lucide-brand package.

@wj25czxj47bu6q
Copy link
Author

Damn, and I've just fixed this too. A new version would be:

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M21.8 13.1a4.36 4.36 0 0 0-.14-3l-2.73-6.68a.72.72 0 0 0-.7-.42.73.73 0 0 0-.66.49L15.52 9h-7l-2.1-5.51a.74.74 0 0 0-1.36-.07l-2.72 6.71a4.36 4.36 0 0 0-.14 3A4.71 4.71 0 0 0 4 15.58l4.17 2.89 3.3 2.37A.94.94 0 0 0 12 21a.87.87 0 0 0 .5-.15l3.32-2.38L20 15.56a4.56 4.56 0 0 0 1.8-2.46Z" />
</svg>

@karsa-mistmere For now, while this issue is in flux, do you have any objection to the use of your new design? (In accordance with the Lucide license or another license of your choosing)

@karsa-mistmere
Copy link
Member

Sure, go ahead, that's why I shared the source code. :)

@mittalyashu
Copy link
Member

mittalyashu commented May 15, 2022

Sorry for burst the bubble.

But, #670

Not sure, if we should even update the existing one's. 🤷

@ericfennis
Copy link
Member

We will drop the support of brand icons after Lucide 1.0. So I close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants