Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit all types used for deserializing from json/toml to ensure we have good error messages. #440

Open
nfachan opened this issue Jan 14, 2025 · 0 comments
Open

Audit all types used for deserializing from json/toml to ensure we have good error messages. #440

nfachan opened this issue Jan 14, 2025 · 0 comments
Labels
maelstrom-run test-runners Issues that affect all test runners (cargo-maelstrom, maelstrom-pytest, maelstrom-to-test, etc.).
Milestone
0.13.0

Comments

@nfachan
Copy link
Collaborator

nfachan commented Jan 14, 2025

In particular, when using untagged enums, we should probably write our own deserialize.

Ensure we have tests for all of them as well, and that the tests make sure we error on unknown fields.
@nfachan nfachan added maelstrom-run test-runners Issues that affect all test runners (cargo-maelstrom, maelstrom-pytest, maelstrom-to-test, etc.). labels Jan 14, 2025
@nfachan nfachan added this to the 0.13.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maelstrom-run test-runners Issues that affect all test runners (cargo-maelstrom, maelstrom-pytest, maelstrom-to-test, etc.).
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
1 participant
@nfachan