Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User Input Bug in M1 #4977

Closed
wants to merge 2 commits into from
Closed

Fix User Input Bug in M1 #4977

wants to merge 2 commits into from

Conversation

victordibia
Copy link
Collaborator

Why are these changes needed?

Fix issue where user input is not collected correctly in m1

Related issue number

Closes #4975

Checks

@victordibia victordibia requested a review from afourney January 9, 2025 23:38
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.60%. Comparing base (90112e1) to head (dcf57f5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../autogen-ext/src/autogen_ext/teams/magentic_one.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4977      +/-   ##
==========================================
- Coverage   68.61%   68.60%   -0.01%     
==========================================
  Files         156      156              
  Lines       10053    10053              
==========================================
- Hits         6898     6897       -1     
- Misses       3155     3156       +1     
Flag Coverage Δ
unittests 68.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afourney afourney mentioned this pull request Jan 9, 2025
@victordibia
Copy link
Collaborator Author

Closing this for now in favor of #4979

@victordibia victordibia closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: Failed to get user input: Failed to get user input:
1 participant