Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the rsa.GenerateKey key size restriction #1468

Open
qmuntal opened this issue Jan 9, 2025 · 0 comments
Open

Remove the rsa.GenerateKey key size restriction #1468

qmuntal opened this issue Jan 9, 2025 · 0 comments
Labels
fips
Milestone
go1.25

Comments

@qmuntal
Copy link
Member

qmuntal commented Jan 9, 2025

We are currently falling back to Go if the RSA key size passed to rsa.GenerakeKey is not 2048, 3072, nor 4096:

https://github.com/golang/go/blob/4225c6cb372e0fea7586dd646e991faa5df20671/src/crypto/rsa/rsa.go#L284

We should remove this restriction and attempt to always generate a key with the crypto backend.
@qmuntal qmuntal added this to the go1.25 milestone Jan 9, 2025
@dagood dagood added the fips label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fips
Projects
None yet
Milestone
go1.25
Development

No branches or pull requests
2 participants
@qmuntal @dagood