Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Text Search AOT enhancements #9342

Closed
9 of 10 tasks
markwallace-microsoft opened this issue Oct 21, 2024 · 0 comments · Fixed by #10143
Closed
9 of 10 tasks

Add unit tests for Text Search AOT enhancements #9342

markwallace-microsoft opened this issue Oct 21, 2024 · 0 comments · Fixed by #10143
Assignees
@markwallace-microsoft
Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Oct 21, 2024 •
edited
Loading

AOT tests for the following methods should be added to the SemanticKernel.AotTests project:

TextSearchExtensions - test that function parameters and return type schema are generated and have the expected shape:

  • KernelPlugin CreateWithSearch(this ITextSearch textSearch, string pluginName, JsonSerializerOptions ...
  • KernelPlugin CreateWithGetTextSearchResults(this ITextSearch textSearch, string pluginName, JsonSerializerOptions ...
  • KernelPlugin CreateWithGetSearchResults(this ITextSearch textSearch, string pluginName, JsonSerializerOptions ...
  • KernelFunction CreateSearch(this ITextSearch textSearch, JsonSerializerOptions ...
  • KernelFunction CreateGetTextSearchResults(this ITextSearch textSearch, JsonSerializerOptions ...
  • KernelFunction CreateGetSearchResults(this ITextSearch textSearch, JsonSerializerOptions ...

TextSearchKernelBuilderExtensions - test that TRecord public properties are not trimmed, and the API can access them:

  • IKernelBuilder AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(...

TextSearchServiceCollectionExtensions - test that TRecord public properties are not trimmed, and the API can access them:

  • IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(...
  • IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(...
  • IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(...
@markwallace-microsoft markwallace-microsoft moved this to Sprint: Planned in Semantic Kernel Oct 21, 2024
@markwallace-microsoft markwallace-microsoft self-assigned this Oct 21, 2024
@markwallace-microsoft markwallace-microsoft added triage sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Oct 21, 2024
@markwallace-microsoft markwallace-microsoft moved this from Sprint: Planned to Sprint: In Progress in Semantic Kernel Jan 8, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2025
@markwallace-microsoft @SergeyMenshykh
.Net: Add unit tests for Text Search AOT enhancements (#10143)
53995c8 
### Motivation and Context

Closes #9342 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: SergeyMenshykh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: Sprint: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Add unit tests for Text Search AOT enhancements markwallace-microsoft/semantic-kernel
1 participant
@markwallace-microsoft