Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No delete button for Tiles #93

Open
Sheila111 opened this issue Mar 2, 2023 · 2 comments
Open

No delete button for Tiles #93

Sheila111 opened this issue Mar 2, 2023 · 2 comments
Assignees
Labels
bug Something isn't working P2

Comments

@Sheila111
Copy link

Sheila111 commented Mar 2, 2023

Describe the bug
No delete button for Tiles

Steps to reproduce the behavior

  1. Navigate to https://arcade.makecode.com/beta#
  2. Create a project and switch to JavaScript editor
  3. Click "Open in VS Code" under simulator
  4. Access the MakeCode Asset Explorer by clicking on the MakeCode icon in the Visual Studio Code action bar
  5. Create a new tile asset

Actual behavior
No delete button for Tiles

Expect behavior
Add delete button for Tiles

Screenshot
image

Additional context
1.OS: Windows11
2.arcade version: 1.13.9
3.Microsoft MakeCode version: 8.6.11

@abchatra abchatra added bug Something isn't working P2 labels Mar 3, 2023
@abchatra abchatra added this to the First release of extension milestone Mar 3, 2023
@jwunderl
Copy link
Member

jwunderl commented Mar 3, 2023

Adding it would just be adding an '|| view == tileExplorer' here, but it would have been intentionally not included because it would break the tilemaps that reference those tiles -- I don't think we do any modification of the .data of assets at all outside the iframe currently and doing so properly would probably be a decent chunk of work (@riknoll to double check?)

I guess another workaround would be to still handle it all in asset frame, and make it so you could set an entry in TileMap.tileset to null and it'd get replaced with transparency next load / on compile or something... but that'd feel real bad to me and feels like something that could result in subtle data loss eventually

image

@jwunderl jwunderl removed this from the First release of extension milestone Mar 9, 2023
@riknoll
Copy link
Member

riknoll commented Mar 9, 2023

yes, i intentionally didn't include it because tiles are annoying to delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2
Projects
None yet
Development

No branches or pull requests

4 participants