Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Suggest: Can git.exe be the top result when git is typed? #237590

Open
Tyriar opened this issue Jan 9, 2025 · 3 comments
Open

Terminal Suggest: Can git.exe be the top result when git is typed? #237590

Tyriar opened this issue Jan 9, 2025 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2025

Not ideal that tab here would use git-lfs:

Image

@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Jan 9, 2025
@meganrogge meganrogge added this to the January 2025 milestone Jan 9, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Jan 9, 2025

Another example:

Image

@meganrogge
Copy link
Contributor

We discussed having a special check in our SimpleCompletionModel for if the word is an exact match minus the extension

@Tyriar
Copy link
Member Author

Tyriar commented Jan 9, 2025

Very similar condition used here:

case 'exactMatchIgnoreExtension': {
runOnEnter = replacementText.toLowerCase() === completionText.toLowerCase();
if (completion.isFile) {
runOnEnter ||= replacementText.toLowerCase() === completionText.toLowerCase().replace(/\.[^\.]+$/, '');
}
break;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest
Projects
None yet
Development

No branches or pull requests

2 participants