-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible merge with feature #66
Comments
Hey @farfromrefug! That sounds great! Feel free to merge to master of this repo. I trust your work and I can do without the overhead atm. Eventually we can release a 3.0.0 based on your work. |
Hi @farfromrefug and @EddyVerbruggen |
@paulgovers not that i know but PRs are always welcome ;) |
@EddyVerbruggen i merged and pushed on the repo. |
@farfromrefug wonderful work 👍 I would like to suggest to set the check of if (opts.headers && opts.headers['Content-Type'].substring(0, 16) === 'application/json') {
manager.requestSerializer = AFJSONRequestSerializer.serializer();
manager.responseSerializer = AFJSONResponseSerializer.serializerWithReadingOptions(
NSJSONReadingOptions.AllowFragments
);
} |
@kefahB indeed! i will go with |
Hey @EddyVerbruggen i have a fork here with a bunch of features and bug fixes:
I tried to create single feature PRs but it was too tough as there are quite a few changes code/structure wise
If you are interested i can create a "big" PR as merge from my master branch so you can test and decide to merge or not.
Would you be interested?
I am also planning on changing a few other things, like not returning a string version of the response but instead do it the same way as {N}. I am even thinking of adding a way to do those "transformations" (toJSON, toString,...) in the native code so that it is done on the background thread
The text was updated successfully, but these errors were encountered: