Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-request-activity-type lacks some possible values values #2621

Open
vittorfp opened this issue Jan 16, 2025 · 1 comment
Open

pull-request-activity-type lacks some possible values values #2621

vittorfp opened this issue Jan 16, 2025 · 1 comment

Comments

@vittorfp
Copy link

vittorfp commented Jan 16, 2025

The list of valid pull-request-activity-type strings is not complete, for example milestoned is not a valid action, as stated in GHA docs: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

Snippet to reproduce:

name: final-review
on:
  pull_request:
    types: [milestoned]


...

Output of act:

Line: 5 Column 12: Failed to match pull-request-activity-types: Line: 5 Column 13: Expected one of assigned,unassigned,labeled,unlabeled,opened,edited,closed,reopened,synchronize,converted_to_draft,ready_for_review,locked,unlocked,review_requested,review_request_removed,auto_merge_enabled,auto_merge_disabled got milestoned

Probably adding the full list of values here would solve.

@ChristopherHX
Copy link
Contributor

Maybe report it to GitHub as well https://github.com/actions/languageservices/blob/main/workflow-parser/src/workflow-v1.0.json ?

I copied that file into act, yes we could alter our copy as well

Open a PR? I only can give +1 review, but you need +2 reviews for a merge

In any case this change from my side would disable the strict check to be not stricter than the GitHub Actions Backend.

However not getting any attention, for required reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants