Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/googlecloudpubsub] Add support for Encoding Extensions #37109

Open
alexvanboxel opened this issue Jan 9, 2025 · 2 comments · May be fixed by #37137
Open

[receiver/googlecloudpubsub] Add support for Encoding Extensions #37109

alexvanboxel opened this issue Jan 9, 2025 · 2 comments · May be fixed by #37137
Labels
enhancement New feature or request receiver/googlecloudpubsub

Comments

@alexvanboxel
Copy link
Contributor

Component(s)

receiver/googlecloudpubsub

Is your feature request related to a problem? Please describe.

The receiver currently supports some build in encodings. The goal is to separate the encodings out of the receiver and put them in their own extension. Before this can happen, the receiver needs to support Encoding Extensions.

Describe the solution you'd like

Reuse the encoding field in the configuration file to select the Encoding Extensions. If non is defined, fall back to the build in encoders.

Describe alternatives you've considered

No response

Additional context

After this change, the cloud_logging encoding will be extracted from the receiver.
@alexvanboxel alexvanboxel added enhancement New feature or request needs triage New item requiring triage labels Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@VihasMakwana
Copy link
Contributor

@alexvanboxel Thanks for opening this request!

Would you also contribute a PR for this?

@VihasMakwana VihasMakwana removed the needs triage New item requiring triage label Jan 9, 2025
alexvanboxel added a commit to alexvanboxel/opentelemetry-collector-contrib that referenced this issue Jan 10, 2025
@alexvanboxel
[receiver/googlecloudpubsub] Add support for encoding extensions (ope…
98e398f 
…n-telemetry#37109)

Added support for encoding extensions. Setting the encoding field in the
config now references the extension. If it didn't find the extension it
will fall back to searching the internal encoders.

To make the build in encoders consistent with the extensions they now
have the same interface.

The README is adapted accordingly.
@alexvanboxel alexvanboxel linked a pull request Jan 10, 2025 that will close this issue
Open
alexvanboxel added a commit to alexvanboxel/opentelemetry-collector-contrib that referenced this issue Jan 10, 2025
@alexvanboxel
[receiver/googlecloudpubsub] Add support for encoding extensions (ope…
8952521 
…n-telemetry#37109)

Added support for encoding extensions. Setting the encoding field in the
config now references the extension. If it didn't find the extension it
will fall back to searching the internal encoders.

To make the build in encoders consistent with the extensions they now
have the same interface.

The README is adapted accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request receiver/googlecloudpubsub
Projects
None yet
Milestone
No milestone
2 participants
@alexvanboxel @VihasMakwana