Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks #29

Open
codefromthecrypt opened this issue Oct 28, 2019 · 0 comments
Open

Add benchmarks #29

codefromthecrypt opened this issue Oct 28, 2019 · 0 comments

Comments

@codefromthecrypt
Copy link
Contributor

We have to be careful that the overhead here doesn't go nuts by accident. We should have scenarios including parsing multiple states with provisioning, especially the TTL logic.

See https://github.com/openzipkin/brave/tree/master/instrumentation/benchmarks/src/main/java/brave/propagation - for benchmarking the general flow

See https://github.com/openzipkin/zipkin/blob/master/benchmarks/src/main/java/zipkin2/internal/ReadBufferBenchmarks.java - for benchmarking the TODO more efficient TTL read/write #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant