Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the over-complicated logic in setup.py #4811

Open
marthacryan opened this issue Oct 21, 2024 · 0 comments · May be fixed by #4970
Open

simplify the over-complicated logic in setup.py #4811

marthacryan opened this issue Oct 21, 2024 · 0 comments · May be fixed by #4970
Labels
feature something new P2 considered for next cycle

Comments

@marthacryan
Copy link
Collaborator

packages/python/plotly/setup.py is a lot more complicated than it appears to need to be (from what I've gathered, this is due to legacy decisions surrounding supporting multiple languages w/ plotly.js?) - it makes making changes to the build system riskier and harder to understand. We should clean it up!
@gvwilson gvwilson changed the title Setup.py contains over-complicated logic simplify the over-complicated logic in setup.py Oct 22, 2024
@gvwilson gvwilson added feature something new P2 considered for next cycle performance something is slow and removed performance something is slow labels Oct 22, 2024
@marthacryan marthacryan linked a pull request Jan 15, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature something new P2 considered for next cycle
Projects
None yet
Milestone
No milestone
2 participants
@gvwilson @marthacryan