-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ESLint v9? #28
Comments
PRs certainly welcome. I think this is a pretty low-priority repo for us and eslint v9 might not be supported w/out community contribution. Edit: You might be able to get away with skipping strict peer deps |
Looks like eslint v9 support might depend on eslint v9 support in the following dependencies:
|
All of the peer dependencies shown above have been updated to support eslint v9. Do we know of any additional changes required for this plugin to support v9? |
eslint-plugin-react-hooks is not yet released in stable :( |
maybe release a rc too which requires a rc of |
at least an RC is available now facebook/react#28773 (comment) |
Just saw this on Twitter: https://github.com/facebook/react/releases/tag/eslint-plugin-react-hooks%405.0.0 Does this mean we're good to go here? Sorry, not an eslint user myself, have to rely a bit on others giving a yay/nay. |
Eslint-plugin-react-hooks now supports v9 as is released: facebook/react#28773 (comment) So all points from watsonarw should be adressed.
|
@watsonarw any other concerns with upgrading to ESLint v9? |
This is intended as a general update to get us on modern toolchains. esbuild v9 support is waiting on preactjs/eslint-config-preact#28 Corresponding changes have been made to get lints, tests, etc. working.
This is intended as a general update to get us on modern toolchains. esbuild v9 support is waiting on preactjs/eslint-config-preact#28 Corresponding changes have been made to get lints, tests, etc. working.
I tried to use ESLint v9.3.0 and got the following error:
Could not resolve dependency:
peer eslint@"6.x || 7.x || 8.x" from [email protected]
Are there any plans to support v9?
The text was updated successfully, but these errors were encountered: