Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ESLint v9? #28

Open
jasonhilldm opened this issue May 19, 2024 · 9 comments · May be fixed by #33
Open

Support for ESLint v9? #28

jasonhilldm opened this issue May 19, 2024 · 9 comments · May be fixed by #33
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jasonhilldm
Copy link

I tried to use ESLint v9.3.0 and got the following error:

Could not resolve dependency:
peer eslint@"6.x || 7.x || 8.x" from [email protected]

Are there any plans to support v9?

@rschristian
Copy link
Member

rschristian commented May 19, 2024

PRs certainly welcome.

I think this is a pretty low-priority repo for us and eslint v9 might not be supported w/out community contribution.

Edit: You might be able to get away with skipping strict peer deps

@rschristian rschristian added good first issue Good for newcomers help wanted Extra attention is needed labels May 19, 2024
@watsonarw
Copy link
Contributor

Looks like eslint v9 support might depend on eslint v9 support in the following dependencies:

Dependency Status Link
eslint-plugin-compat ⛔ Not supported yet amilajack/eslint-plugin-compat#614
eslint-plugin-jest ⚒️ Supported from v28 https://github.com/jest-community/eslint-plugin-jest/releases/tag/v28.0.0
eslint-plugin-react ⛔ Not supported yet jsx-eslint/eslint-plugin-react#3699
eslint-plugin-react-hooks ⛔ Updated, pending release facebook/react#28773 (comment)

@mhamann
Copy link

mhamann commented Aug 27, 2024

All of the peer dependencies shown above have been updated to support eslint v9. Do we know of any additional changes required for this plugin to support v9?

@euskadi31
Copy link

euskadi31 commented Sep 6, 2024

eslint-plugin-react-hooks is not yet released in stable :(

see: facebook/react#28773 (comment)

@hbroer
Copy link

hbroer commented Sep 30, 2024

maybe release a rc too which requires a rc of eslint-plugin-react-hooks? This blocks our eslint update since months and we don't even use hooks ;-)

@rburgst
Copy link

rburgst commented Oct 1, 2024

at least an RC is available now facebook/react#28773 (comment)

@rschristian
Copy link
Member

Just saw this on Twitter: https://github.com/facebook/react/releases/tag/eslint-plugin-react-hooks%405.0.0

Does this mean we're good to go here? Sorry, not an eslint user myself, have to rely a bit on others giving a yay/nay.

@JonasKellerer
Copy link

Eslint-plugin-react-hooks now supports v9 as is released: facebook/react#28773 (comment)

So all points from watsonarw should be adressed.

Looks like eslint v9 support might depend on eslint v9 support in the following dependencies:
Dependency Status Link
eslint-plugin-compat ⛔ Not supported yet amilajack/eslint-plugin-compat#614
eslint-plugin-jest ⚒️ Supported from v28 https://github.com/jest-community/eslint-plugin-jest/releases/tag/v28.0.0
eslint-plugin-react ⛔ Not supported yet jsx-eslint/eslint-plugin-react#3699
eslint-plugin-react-hooks ⛔ Updated, pending release facebook/react#28773 (comment)

@brianrodri
Copy link

@watsonarw any other concerns with upgrading to ESLint v9?

kujenga added a commit to kujenga/website that referenced this issue Jan 12, 2025
This is intended as a general update to get us on modern toolchains.

esbuild v9 support is waiting on preactjs/eslint-config-preact#28

Corresponding changes have been made to get lints, tests, etc. working.
kujenga added a commit to kujenga/website that referenced this issue Jan 13, 2025
This is intended as a general update to get us on modern toolchains.

esbuild v9 support is waiting on preactjs/eslint-config-preact#28

Corresponding changes have been made to get lints, tests, etc. working.
@brianrodri brianrodri linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants