Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #pragma that disables optimization on _PyEval_EvalFrameDefault on MSVC #129244

Closed
mdboom opened this issue Jan 23, 2025 · 1 comment
Closed

Remove #pragma that disables optimization on _PyEval_EvalFrameDefault on MSVC #129244

mdboom opened this issue Jan 23, 2025 · 1 comment
Assignees
@mdboom
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows performance Performance or resource usage type-feature A feature request or enhancement

Comments

@mdboom
Copy link
Contributor

mdboom commented Jan 23, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

The bug that caused a compiler crash has now been fixed upstream. We should remove our workaround to disable optimization on PGO builds on MSVC (and presumably get a modest speedup).

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@mdboom mdboom added the type-feature A feature request or enhancement label Jan 23, 2025
@mdboom mdboom self-assigned this Jan 23, 2025
@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jan 24, 2025
@encukou encukou added the performance Performance or resource usage label Jan 24, 2025
@bedevere-app bedevere-app bot mentioned this issue Jan 24, 2025
Merged
mdboom added a commit that referenced this issue Jan 25, 2025
@mdboom
gh-129244: Remove workaround for MSVC compiler crash (#129263)
9e52e55 
* Remove compiler workaround

* Remote _Py_USING_PGO
@itamaro
Copy link
Contributor

itamaro commented Jan 25, 2025

Looks like this is done, closing.

@itamaro itamaro closed this as completed Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdboom mdboom

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows performance Performance or resource usage type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdboom @itamaro @encukou @picnixz