Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS buildbot failure comments don't contain failure details anymore #129248

Closed
mhsmith opened this issue Jan 23, 2025 · 1 comment · Fixed by #129252
Closed

iOS buildbot failure comments don't contain failure details anymore #129248

mhsmith opened this issue Jan 23, 2025 · 1 comment · Fixed by #129252
Labels
OS-ios type-bug An unexpected behavior, bug, or error

Comments

@mhsmith
Copy link
Member

mhsmith commented Jan 23, 2025 •
edited by bedevere-app bot
Loading

Specificially, they don't contain:

  • The names of the failed tests
  • The tracebacks

It looks like this changed in December 2024, probably because the test script was updated to add a prefix to every log line. The relevant regexes are here.

Before:

After:

@freakboy3742: FYI

Linked PRs
@mhsmith mhsmith added OS-ios type-bug An unexpected behavior, bug, or error labels Jan 23, 2025
@freakboy3742
Copy link
Contributor

Yeah - this will be a result of #127592. The log prefix doesn't really help diagnose anything, so I'll strip it (matching what Android does with its logger).

@freakboy3742 freakboy3742 mentioned this issue Jan 24, 2025
Merged
freakboy3742 added a commit that referenced this issue Jan 25, 2025
@freakboy3742
gh-129248: Filter out the iOS log prefix from testbed runner output. (#…
a580838 
…129252)

Filter out the iOS log prefix from testbed runner output.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 25, 2025
@freakboy3742 @miss-islington
pythongh-129248: Filter out the iOS log prefix from testbed runner ou…
ebcac45 
…tput. (pythonGH-129252)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a58083811a51764c47fbb7cbd67e87e1124d53e8)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 25, 2025
Merged
freakboy3742 added a commit that referenced this issue Jan 25, 2025
@miss-islington @freakboy3742
[3.13] gh-129248: Filter out the iOS log prefix from testbed runner o…
aa1beed 
…utput. (GH-129252) (#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-ios type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-129248: Filter out the iOS log prefix from testbed runner output. freakboy3742/cpython
2 participants
@freakboy3742 @mhsmith