allow-unwrap-in-tests vs #![cfg_attr(test, allow(clippy::unwrap_used))]

[mladedav]

I am wondering why does the option exist in clippy.toml. Is there a difference between these two?

[flip1995]

Using cfg_attr(test) will disable the lint in all code, not only test code when you run cargo clippy --tests or cargo clippy --all-targets. The setting in the clippy.toml file will make the lint check, if the unwrap is in a test context (a function marked with #[test] or a test module), and not trigger there.

[mladedav]

Having this code still emits an error for the first unwrap while it does not for the second one even with cargo clippy --all-targets and cargo clippy --tests:

#![allow(clippy::unnecessary_literal_unwrap)]
#![allow(dead_code)]
#![warn(clippy::unwrap_used)]
#![cfg_attr(test, allow(clippy::unwrap_used))]

fn code() {
    Some("code").unwrap();
}

#[test]
fn test() {
    Some("test").unwrap();
}

If I understand correctly your answer, this example should not have emitted anything, right?

[mladedav]

Gentle ping @flip1995. I just want to know if I maybe misunderstood your answer or there is something else happening during the compilation.

I get this is a minor thing so if you don't have the time to dig into the details about this, that's fine too.