Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove patched cc-rs revision from bootstrap after armv7a-vex-v5 target is merged. #136075

Closed
Tropix126 opened this issue Jan 26, 2025 · 2 comments
Closed

cleanup: Remove patched cc-rs revision from bootstrap after armv7a-vex-v5 target is merged. #136075

Tropix126 opened this issue Jan 26, 2025 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@Tropix126
Copy link

cc-rs currently retrieves a list of target specifications from the latest nightly build of rustc, making it impossible to bootstrap new targets without using a patched version of the cc dependency. This is the case with #131530, which adds the armv7a-vex-v5 T3 target. After the PR is merged/approved and a nightly is released and whatnot, the revision should be removed.

See https://github.com/rust-lang/rust/pull/131530/files#diff-bc6db3ba5470d55424f84b8accb942d6b65345d468c6e8e330e17b692fea09cbR102
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 26, 2025
@Tropix126
Copy link
Author

Tropix126 commented Jan 26, 2025 •
edited
Loading

This also applies to src/tools/tidy, see the review at https://github.com/rust-lang/rust/pull/131530/files#diff-d642ecacb161b068b8a3f539811356ccec69c5da1604182bb775ab46e1f891ddR12

@lolbinarycat lolbinarycat added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jan 26, 2025
@Tropix126
Copy link
Author

Tropix126 commented Jan 26, 2025 •
edited
Loading

Closing due to #131530 being closed and hopefully split into smaller changes in the future. My hope is that targets won't have to patch cc-rs through bootstrap by the time the compiler-side of this work is ready for review, but this may need to be addressed again once that PR is opened.

@Tropix126 Tropix126 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lolbinarycat @jieyouxu @Tropix126 @rustbot