Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate planning commands from running them? #436

Open
sourcefrog opened this issue Nov 11, 2024 · 0 comments
Open

Separate planning commands from running them? #436

sourcefrog opened this issue Nov 11, 2024 · 0 comments
Labels
internal Internal refactors and infrastructure

Comments

@sourcefrog
Copy link
Owner

As the logic for what commands to run gets more complex it might be useful to separate the logic that plans commands to run, from the code that actually runs them.

Then we could write some tests that only inspect the generated commands without actually running them, which would make the test suite faster. However the speed would come at the risk of the tests being perhaps less realistic: we wouldn't catch cases where the cargo command semantics don't do what we expect.

Also, this might just make the code easier to follow.

@sourcefrog sourcefrog added the internal Internal refactors and infrastructure label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactors and infrastructure
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant