Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Document to a neo4j vector store needlessly overwrites all its properties #1932

Closed
enricorampazzo opened this issue Dec 14, 2024 · 4 comments · May be fixed by #2070
Closed

Adding a Document to a neo4j vector store needlessly overwrites all its properties #1932

enricorampazzo opened this issue Dec 14, 2024 · 4 comments · May be fixed by #2070
Labels
enhancement New feature or request
Milestone
1.0.0-M6

Comments

@enricorampazzo
Copy link

spring-ai/vector-stores/spring-ai-neo4j-store/src/main/java/org/springframework/ai/vectorstore/Neo4jVectorStore.java

Line 125 in 9e18652

SET u = {}

Because of this line, when an existing node is added to the vector store, its existing properties are deleted, and only those added as document metadata are persisted.

This is needlessly destructive. I suggest to change line 125 to SET u = properties(u) so that existing properties are preserved
meistermeier added a commit to meistermeier/spring-ai that referenced this issue Jan 15, 2025
@meistermeier
Neo4j module: remove unnecessary property removal.
93951a8 
Closes spring-projects#1932

Signed-off-by: Gerrit Meier <[email protected]>
@meistermeier
Copy link
Contributor

It was there since the beginning, but I have no exact idea why we / I did this anymore.
I think it was because we wanted to persist the document as it comes in . But if it makes trouble, I have no problem in removing those lines and compress it.

@meistermeier meistermeier mentioned this issue Jan 15, 2025
Open
@enricorampazzo
Copy link
Author

Maybe I am using it wrongly, but what I normally do is I create records in a db, with some text I want to embed, and if I want to use that record later, all its properties will be removed, unless I set them in the metadata, which seems clunky, but again, maybe I am missing something

@meistermeier
Copy link
Contributor

There is now the PR (#2070) for this. I also would say it's ok to keep the existing properties.

@sobychacko
Copy link
Contributor

Looks good. Merged the changes upstream. Thanks for looking into it.

@sobychacko sobychacko added this to the 1.0.0-M6 milestone Jan 16, 2025
@sobychacko sobychacko added the enhancement New feature or request label Jan 16, 2025
StudiousXiaoYu pushed a commit to StudiousXiaoYu/spring-ai that referenced this issue Jan 21, 2025
@meistermeier @StudiousXiaoYu
Neo4j module: remove unnecessary property removal.
6c0cc84 
Closes spring-projects#1932

Signed-off-by: Gerrit Meier <[email protected]>
Signed-off-by: StudiousXiaoYu <[email protected]>
leijendary pushed a commit to leijendary/spring-ai that referenced this issue Jan 24, 2025
@meistermeier @leijendary
Neo4j module: remove unnecessary property removal.
fa954d9 
Closes spring-projects#1932

Signed-off-by: Gerrit Meier <[email protected]>
Signed-off-by: leijendary <[email protected]>
leijendary pushed a commit to leijendary/spring-ai that referenced this issue Jan 24, 2025
@meistermeier @leijendary
Neo4j module: remove unnecessary property removal.
e094fac 
Closes spring-projects#1932

Signed-off-by: Gerrit Meier <[email protected]>
Signed-off-by: leijendary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-M6
Development

Successfully merging a pull request may close this issue.

Neo4j module: remove unnecessary property removal. meistermeier/spring-ai
3 participants
@meistermeier @sobychacko @enricorampazzo